Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[343] Task output file supports TES internal location in Terra #344

Merged
merged 3 commits into from
Aug 9, 2023
Merged

[343] Task output file supports TES internal location in Terra #344

merged 3 commits into from
Aug 9, 2023

Conversation

giventocode
Copy link
Contributor

@giventocode giventocode commented Aug 9, 2023 •
edited
Loading

Fixes: #343

This PR includes:

  • New logic to handle the TES internal URL when creating the output file destination for clean-up task.
  • Tests that validate correct behavior when the TES internal URL contains additional segments (Terra scenario) and when it does not ( CoA).

@giventocode giventocode requested review from jsaun and BMurri August 9, 2023 14:34
@giventocode giventocode marked this pull request as draft August 9, 2023 14:57
@giventocode giventocode marked this pull request as ready for review August 9, 2023 15:27
@giventocode giventocode changed the title [343] Start-up output file supports TES internal location in Terra [343] Task output file supports TES internal location in Terra Aug 9, 2023
@giventocode giventocode merged commit cc53a4e into main Aug 9, 2023
@giventocode giventocode deleted the ja-343 branch August 9, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattMcL4475 MattMcL4475 MattMcL4475 approved these changes

@jsaun jsaun Awaiting requested review from jsaun

@BMurri BMurri Awaiting requested review from BMurri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File outputs destination for cloud task is incorrect when TES is running on Terra
2 participants
@giventocode @MattMcL4475