Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new Github build/test action and update NetworkUtility tests #292

Merged
merged 20 commits into from
Jul 18, 2023

Conversation

MattMcL4475
Copy link
Collaborator

@MattMcL4475 MattMcL4475 commented Jul 16, 2023

Add new build/test actions to Github. Requires approval for all outside collaborators to run.

Also updates NetworkUtility to only block outbound network packets, and modifies tests to work in the Github action.

Resolves: #293

@MattMcL4475 MattMcL4475 requested review from giventocode, BMurri and jsaun and removed request for BMurri July 18, 2023 15:21
@MattMcL4475 MattMcL4475 marked this pull request as ready for review July 18, 2023 15:22
@MattMcL4475 MattMcL4475 requested a review from BMurri July 18, 2023 15:22
@MattMcL4475 MattMcL4475 changed the title Create new Github build and test action Create new Github build/test action and update NetworkUtility tests Jul 18, 2023
Copy link
Contributor

@giventocode giventocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MattMcL4475 MattMcL4475 merged commit 3c9a10a into main Jul 18, 2023
@MattMcL4475 MattMcL4475 deleted the MattMcL4475/AddGithubBuildAction branch July 18, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new Github build and test actions
3 participants