Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Docker container IMDS access #286

Merged
merged 17 commits into from
Jul 15, 2023
Merged

Block Docker container IMDS access #286

merged 17 commits into from
Jul 15, 2023

Conversation

MattMcL4475
Copy link
Collaborator

@MattMcL4475 MattMcL4475 commented Jul 12, 2023 •
edited
Loading

Resolves #288

@MattMcL4475 MattMcL4475 requested a review from giventocode July 12, 2023 22:12
@BMurri
Copy link
Collaborator

BMurri commented Jul 12, 2023

Needs an open issue

giventocode
giventocode approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@giventocode giventocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor suggestions.

@MattMcL4475 MattMcL4475 merged commit 4dd9e6a into main Jul 15, 2023
@MattMcL4475 MattMcL4475 deleted the mattmcl4475/blockDockerAccessToImds branch July 15, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giventocode giventocode giventocode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block Docker IMDS access on Batch node
3 participants
@MattMcL4475 @BMurri @giventocode