-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snap to specific dot net to fix dotnet format #241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The downside here is that this will force the entire build to run under 7.0.203, which has been superseded by 7.0.302 (in fact, upgrading VS 2022 will replace 203 with 302). I don't know if we will run into any issues with release processes. This should be short-term only (until dotnet fixes their stuff).
I don't know how to rescind my approval, but this isn't building in the pipeline because 7.0.203 has already been blacklisted for releasing new code. |
@BMurri adusted this so the global.json is only used for the github action, not for the project (it lives in the format directory). Let me know if you think this is a reasonable alternative for now. |
I had to look this up too, so putting here for the future: https://stackoverflow.com/questions/63910871/how-could-i-remove-my-approval-from-a-pull-request-on-github |
Perfect. Ship it:tm: |
our issue that tracks this: #242
explanation regarding why we need the global.json, apparently just specifying it in the step in github action doesnt actually do anything: https://github.com/actions/setup-dotnet#usage