Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share global options instead of recreating them multiple times #239

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

BMurri
Copy link
Collaborator

@BMurri BMurri commented Jun 2, 2023

fixes #238

Copy link
Contributor

@giventocode giventocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one nit comment.

}

private static Option<T> CreateOption<T>(string name, string description, string alias, bool required = false, object? defaultValue = null)
private static Option<T> CreateOption<T>(string name, string description, string alias, bool required = false, object? defaultValue = null, System.CommandLine.Parsing.ParseArgument<T>? parse = null, Action<Option<T>>? configureOption = null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any call to CreateOption that uses the last two arguments.

@BMurri BMurri merged commit 6272214 into main Jun 6, 2023
@BMurri BMurri deleted the bmurri/tes-runner-command-factory branch June 6, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address issues with sharing Options from System.CommandLine across Commands
2 participants