[148] Transfer settings optimizer #219
Conversation
| } | ||
| } | ||
|
|
||
| public long TotalMemory |
There was a problem hiding this comment.
is this in bytes or a different unit? Would be helpful to name variable as such
| { | ||
| get | ||
| { | ||
| return (long)(Convert.ToUInt64(File.ReadLines(ProcMemInfo).First(line => line.StartsWith("MemTotal")).Split(' ', StringSplitOptions.RemoveEmptyEntries)[1]) * 1024); |
There was a problem hiding this comment.
Could Convert.ToInt64 instead of casting ulong as long? Also could store this in a static variable so the file system is only used once
| private readonly ISystemInfoProvider systemInfoProvider; | ||
| private const double MemoryBufferCapacityFactor = 0.4; // 40% of total memory | ||
| private const long MaxMemoryBufferSizeInBytes = BlobSizeUtils.GiB * 2; // 2 GiB of total memory | ||
| private const int MaxNumberOfWorkingOfThreads = 90; |
There was a problem hiding this comment.
maybe rename to MaxWorkingThreadsCount. I'm surprised it's not valuable to vary this based on core count?
| private BlobPipelineOptions CreateOptimizedOptions(BlobPipelineOptions options) | ||
| { | ||
| var blockSize = GetBlockSize(options.BlockSizeBytes); | ||
| var bufferCapacity = GetOptimizedMemoryBufferCapacity(blockSize); |
There was a problem hiding this comment.
what unit is this? If bytes, helpful to have variable name include it
|
|
||
| private BlobPipelineOptions CreateOptimizedOptions(BlobPipelineOptions options) | ||
| { | ||
| var blockSize = GetBlockSize(options.BlockSizeBytes); |
| return ToTens((int)(Convert.ToInt64(memoryBuffer) / blockSize)); | ||
| } | ||
|
|
||
| private int ToTens(int value) |
There was a problem hiding this comment.
RoundDownToNearestTen() might be more descriptive
| { | ||
| get | ||
| { | ||
| return File.ReadLines(ProcCpuInfo).Count(line => line.StartsWith("processor")); |
There was a problem hiding this comment.
maybe just do this once, and then store it in a static variable, since this will never change in the process lifetime, and multiple invocations of the file system isn't ideal?
This PR includes: