Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TES node runner project #211

Merged
merged 28 commits into from
May 4, 2023
Merged

TES node runner project #211

merged 28 commits into from
May 4, 2023

Conversation

giventocode
Copy link
Contributor

@giventocode giventocode commented May 1, 2023 •
edited
Loading

This is the initial PR of the TES node runner. A few things to call out:

  • This PR includes three new projects, Tes.Runner class library with the core implementation, Tes.Runner.Test test project for the library, and Tes.RunnerCLI a lightweight CLI wrapper for the library and the entry-point for execution. Checkout README for more details.
  • The initial focus is on the download and upload operations so we can migrate those first - checkout [Feature] Implement TES Task Runner  #148 for more details.
  • Contains initial implementation for the Docker execution using the Docker API, but follow up work is needed to iron out edge-cases and better error handling.
  • The test project, includes integration tests, however these are disabled ([Ignore]) for now as they require Azurite which I think is not included in our build pipelines.
  • Closes: [#148 Implement TES Task Runner] Merge TES Task runner code in the TES repo #143

MattMcL4475
MattMcL4475 reviewed May 3, 2023
View reviewed changes
MattMcL4475 and others added 3 commits May 4, 2023 10:06
@MattMcL4475
Minor formatting changes (#213)
5fe79cc 
* minor reformatting

* minor updates

* minor

* minor

* whitespace

* minor
@giventocode
feedback merge, and formatting
d2ee55c
@giventocode
minor renaming.
104f9a2
@giventocode giventocode merged commit 22a229f into main May 4, 2023
@giventocode giventocode deleted the ja-tes-runner branch May 4, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattMcL4475 MattMcL4475 MattMcL4475 approved these changes

@jsaun jsaun Awaiting requested review from jsaun

@BMurri BMurri Awaiting requested review from BMurri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[#148 Implement TES Task Runner] Merge TES Task runner code in the TES repo
2 participants
@giventocode @MattMcL4475