Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerous small bug fixes, dead code removal, formatting consistency, removed implementation deails from interfaces, etc #203

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

BMurri
Copy link
Collaborator

@BMurri BMurri commented Apr 13, 2023

Bug fixes:

  • Used enumeration extension to ensure that paged list APIs will, if needed, pull all items (instead of just the first page) (see ToAsyncEnumerable.
  • Added scope to singleton app cache keys.
  • Ensured that async methods inside non-async methods were calling the async methods in such a way to ensure that the data requested would really be returned (see AsTask).
  • Fixed bugs parsing exceptions and in a finally block where the cleanup code would never have worked as written.
  • Fixed some grammar and wording in messages.

Removed unused code, except for code referenced in commented out code. There, I commented it out.

Moved some code out if places it probably should never have been placed originally (yes, I'm the one that placed it there ;)).

Made some code edits to make formatting more consistent (sometimes within a given file, sometimes across the codebase).

…removed

implementation deails from interfaces, etc
@BMurri BMurri requested a review from MattMcL4475 April 13, 2023 08:10
@BMurri BMurri merged commit 3a4f6de into main Apr 13, 2023
@BMurri BMurri deleted the bmurri/misc-fixes branch April 13, 2023 17:28
@ngambani ngambani added this to the 4.3.0 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants