Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay deletion of unavailable pool until all tasks are fully processed #200

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

BMurri
Copy link
Collaborator

@BMurri BMurri commented Apr 13, 2023

This prevents errors caused when Scheduler hasn't processed all completed tasks in the job associated with the pool that is now being rotated out.

This also jump-starts the targeting change by priming the reenabled auto-scale formula with the current number of pending tasks, rather then the current target. Any errors determining the current number of tests will lead to falling back to the previous behavior.

@BMurri BMurri requested a review from MattMcL4475 April 13, 2023 03:25
@BMurri BMurri merged commit d55b009 into main Apr 13, 2023
@BMurri BMurri deleted the bmurri/delay-pool-deletion-completed-task-processing branch April 13, 2023 16:52
@ngambani ngambani added this to the 4.3.0 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants