Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase the hashes in pool/job names #198

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

BMurri
Copy link
Collaborator

@BMurri BMurri commented Apr 13, 2023

I've discovered that seas of uppercase characters leads to severe eye strain, and we are not expecting anyone to have to retype any of these names.

@BMurri BMurri requested a review from MattMcL4475 April 13, 2023 01:24
MattMcL4475
MattMcL4475 previously approved these changes Apr 13, 2023
@MattMcL4475 MattMcL4475 self-requested a review April 13, 2023 16:55
@MattMcL4475 MattMcL4475 dismissed their stale review April 13, 2023 16:58

2nd thoughts

@BMurri BMurri merged commit 0a7838f into main Apr 13, 2023
@BMurri BMurri deleted the bmurri/pool-job-name-hashes-lowercase branch April 13, 2023 18:39
@ngambani ngambani added this to the 4.3.0 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants