Trim '?' off SAS Tokens #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattMcL4475
reviewed
Apr 12, 2023
src/TesApi.Web/BatchScheduler.cs
Outdated
| public string SasToken | ||
| { | ||
| get => sasToken; | ||
| set => sasToken = value.TrimStart('?'); |
There was a problem hiding this comment.
add the null-conditional operator in case someone tries to set as null
set => sasToken = value?.TrimStart('?');
MattMcL4475
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #638
This PR expands SAS Token properties' setters to trim off any possible leading '?' characters.
There appears to be one other place a SAS Token is referenced in
GetMappedSasContainerUrlFromWsmAsync()but that's already trimming a leading/caracter