Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache optimization for completed tasks #192

Merged
merged 13 commits into from
May 12, 2023

Conversation

MattMcL4475
Copy link
Collaborator

@MattMcL4475 MattMcL4475 commented Apr 10, 2023

Currently, all completed TES tasks are removed from the repository's cache when retrieved. This is a slight modification to only remove tasks that are completed with no errors, AND tasks that are completed with errors and the caller is requesting the FULL view. This should eliminate all cache misses. Resolves #227

@MattMcL4475 MattMcL4475 marked this pull request as draft April 10, 2023 17:06
@MattMcL4475 MattMcL4475 requested a review from BMurri April 10, 2023 17:21
@MattMcL4475 MattMcL4475 marked this pull request as ready for review April 14, 2023 21:27
@MattMcL4475 MattMcL4475 added this to the 4.4.0 milestone Apr 28, 2023
@BMurri
Copy link
Collaborator

BMurri commented Apr 28, 2023

src/TesApi.Web/RepositoryRetryHandler.cs(20,53): error CS0535: 'RepositoryRetryHandler<T>' does not implement interface member 'IRepository<T>.TryRemoveItemFromCacheAsync(T)' [/home/runner/work/ga4gh-tes/ga4gh-tes/src/TesApi.Web/TesApi.Web.csproj]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants