Adding dotnet format to repo #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattMcL4475
approved these changes
Apr 12, 2023
ashanhol
reviewed
Apr 18, 2023
| @@ -138,9 +138,9 @@ public void ConfigureServices(IServiceCollection services) | |||
| .AddHostedService<DeleteCompletedBatchJobsHostedService>() | |||
| .AddHostedService<DeleteOrphanedBatchJobsHostedService>() | |||
| .AddHostedService<DeleteOrphanedAutoPoolsHostedService>(); | |||
| //.AddHostedService<RefreshVMSizesAndPricesHostedService>() | |||
| //.AddHostedService<RefreshVMSizesAndPricesHostedService>() | |||
There was a problem hiding this comment.
Nit: This looks weird. @MattMcL4475 git blame tells me this comment line is yours, can it be deleted?
There was a problem hiding this comment.
It's a placeholder RN because it appears that the PriceApi is still making calls out for each new task even though it "warmed itself up" when TES started.
ashanhol
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has changes to files that came up after running dotnet format locally.
It also includes a new github action that will kick off a dotnet format run on PR creation
related to following issue: microsoft/CromwellOnAzure#570