Add convenient initialization of TesClient with a TesCredentials (#718)

microsoft · Jun 10, 2024 · 3dd23d9 · 3dd23d9
1 parent b9a39c7
commit 3dd23d9
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/Tes.SDK.Tests/TesClientTests.cs b/src/Tes.SDK.Tests/TesClientTests.cs
@@ -17,7 +17,7 @@ public class TesClientTests
         public void Initialize()
         {
             _httpClientMock = new Mock<HttpClient>();
-            _client = new TesClient(_httpClientMock.Object, new("https://example.com"));
+            _client = new TesClient(_httpClientMock.Object, new Uri("https://example.com"));
         }
 
         [TestCleanup]

diff --git a/src/Tes.SDK/TesClient.cs b/src/Tes.SDK/TesClient.cs
@@ -80,6 +80,21 @@ public TesClient(Uri baseUrl, string username, string password)
             ArgumentException.ThrowIfNullOrEmpty(password);
         }
 
+        public TesClient(TesCredentials tesCredentials, string scheme = "https")
+            : this(new($"{scheme}://{tesCredentials.TesHostname}"), tesCredentials.TesUsername, tesCredentials.TesPassword)
+        {
+            ArgumentException.ThrowIfNullOrWhiteSpace(tesCredentials.TesHostname, nameof(tesCredentials));
+        }
+
+        public TesClient(HttpClient httpClient, TesCredentials tesCredentials, string scheme = "https")
+            : this(httpClient, new($"{scheme}://{tesCredentials.TesHostname}"), tesCredentials.TesUsername, tesCredentials.TesPassword)
+        {
+            ArgumentNullException.ThrowIfNull(tesCredentials);
+            ArgumentException.ThrowIfNullOrWhiteSpace(tesCredentials.TesHostname, nameof(tesCredentials));
+            ArgumentException.ThrowIfNullOrWhiteSpace(tesCredentials.TesUsername, nameof(tesCredentials));
+            ArgumentException.ThrowIfNullOrEmpty(tesCredentials.TesPassword, nameof(tesCredentials));
+        }
+
         private void SetAuthorizationHeader(HttpRequestMessage request)
         {
             if (!string.IsNullOrWhiteSpace(_username) && !string.IsNullOrEmpty(_password))