chore: update projects to use * for inner workspace dependencies
#28426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
* for workspace dependencies
Hotell
force-pushed
the
hotell/deps/move-to-star-for-apps-deps-2
branch
3 times, most recently
from
d3c8e0f to
81becec
Compare
Hotell
changed the title
* for workspace dependencies* for inner workspace dependencies
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 76 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 606 | 597 | 5000 | |
| Button | mount | 297 | 291 | 5000 | |
| Field | mount | 1068 | 1037 | 5000 | |
| FluentProvider | mount | 667 | 650 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 91 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 81 | 70 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 76 | 10 | Possible regression |
| InfoButton | mount | 16 | 14 | 5000 | |
| MakeStyles | mount | 834 | 842 | 50000 | |
| Persona | mount | 1632 | 1593 | 5000 | |
| SpinButton | mount | 1317 | 1308 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ccea3d0:
|
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 85 | 76 | 1.12:1 |
| ListMinimalPerf.default | 330 | 304 | 1.09:1 |
| RadioGroupMinimalPerf.default | 272 | 255 | 1.07:1 |
| AvatarMinimalPerf.default | 110 | 105 | 1.05:1 |
| HeaderMinimalPerf.default | 220 | 210 | 1.05:1 |
| RefMinimalPerf.default | 110 | 105 | 1.05:1 |
| AccordionMinimalPerf.default | 87 | 84 | 1.04:1 |
| PortalMinimalPerf.default | 86 | 83 | 1.04:1 |
| SkeletonMinimalPerf.default | 206 | 199 | 1.04:1 |
| TextAreaMinimalPerf.default | 293 | 282 | 1.04:1 |
| TooltipMinimalPerf.default | 1311 | 1263 | 1.04:1 |
| AttachmentSlotsPerf.default | 645 | 629 | 1.03:1 |
| ChatWithPopoverPerf.default | 190 | 185 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 723 | 703 | 1.03:1 |
| ProviderMergeThemesPerf.default | 677 | 655 | 1.03:1 |
| ButtonSlotsPerf.default | 309 | 302 | 1.02:1 |
| DropdownManyItemsPerf.default | 406 | 397 | 1.02:1 |
| EmbedMinimalPerf.default | 1892 | 1855 | 1.02:1 |
| ReactionMinimalPerf.default | 216 | 212 | 1.02:1 |
| SegmentMinimalPerf.default | 202 | 199 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2282 | 2233 | 1.02:1 |
| TableMinimalPerf.default | 240 | 236 | 1.02:1 |
| VideoMinimalPerf.default | 452 | 444 | 1.02:1 |
| AnimationMinimalPerf.default | 293 | 290 | 1.01:1 |
| CarouselMinimalPerf.default | 271 | 268 | 1.01:1 |
| DropdownMinimalPerf.default | 1428 | 1408 | 1.01:1 |
| FlexMinimalPerf.default | 162 | 161 | 1.01:1 |
| HeaderSlotsPerf.default | 467 | 462 | 1.01:1 |
| InputMinimalPerf.default | 545 | 541 | 1.01:1 |
| ListNestedPerf.default | 321 | 317 | 1.01:1 |
| ListWith60ListItems.default | 353 | 350 | 1.01:1 |
| LoaderMinimalPerf.default | 197 | 196 | 1.01:1 |
| MenuButtonMinimalPerf.default | 964 | 959 | 1.01:1 |
| PopupMinimalPerf.default | 353 | 349 | 1.01:1 |
| SliderMinimalPerf.default | 753 | 746 | 1.01:1 |
| TextMinimalPerf.default | 191 | 189 | 1.01:1 |
| TreeMinimalPerf.default | 482 | 476 | 1.01:1 |
| ChatDuplicateMessagesPerf.default | 160 | 160 | 1:1 |
| CheckboxMinimalPerf.default | 1111 | 1114 | 1:1 |
| DatepickerMinimalPerf.default | 3612 | 3612 | 1:1 |
| DialogMinimalPerf.default | 446 | 448 | 1:1 |
| DividerMinimalPerf.default | 204 | 205 | 1:1 |
| CustomToolbarPrototype.default | 1467 | 1464 | 1:1 |
| GridMinimalPerf.default | 189 | 190 | 0.99:1 |
| ImageMinimalPerf.default | 226 | 228 | 0.99:1 |
| LabelMinimalPerf.default | 220 | 223 | 0.99:1 |
| MenuMinimalPerf.default | 497 | 503 | 0.99:1 |
| RosterPerf.default | 1542 | 1557 | 0.99:1 |
| IconMinimalPerf.default | 383 | 388 | 0.99:1 |
| BoxMinimalPerf.default | 193 | 197 | 0.98:1 |
| ButtonMinimalPerf.default | 86 | 88 | 0.98:1 |
| CardMinimalPerf.default | 303 | 309 | 0.98:1 |
| FormMinimalPerf.default | 218 | 222 | 0.98:1 |
| LayoutMinimalPerf.default | 208 | 212 | 0.98:1 |
| ListCommonPerf.default | 390 | 398 | 0.98:1 |
| TableManyItemsPerf.default | 1114 | 1139 | 0.98:1 |
| ToolbarMinimalPerf.default | 535 | 548 | 0.98:1 |
| TreeWith60ListItems.default | 83 | 85 | 0.98:1 |
| ChatMinimalPerf.default | 438 | 451 | 0.97:1 |
| ProviderMinimalPerf.default | 207 | 214 | 0.97:1 |
| StatusMinimalPerf.default | 383 | 399 | 0.96:1 |
| ButtonOverridesMissPerf.default | 647 | 685 | 0.94:1 |
| AlertMinimalPerf.default | 144 | 157 | 0.92:1 |
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8d06e6d07e96f556e72b7a597664f14bef933eac (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 626 | 606 | 5000 | |
| Breadcrumb | mount | 1699 | 1684 | 1000 | |
| Checkbox | mount | 1713 | 1714 | 5000 | |
| CheckboxBase | mount | 1478 | 1471 | 5000 | |
| ChoiceGroup | mount | 2925 | 2939 | 5000 | |
| ComboBox | mount | 651 | 672 | 1000 | |
| CommandBar | mount | 6340 | 6315 | 1000 | |
| ContextualMenu | mount | 13959 | 13997 | 1000 | |
| DefaultButton | mount | 741 | 761 | 5000 | |
| DetailsRow | mount | 2194 | 2176 | 5000 | |
| DetailsRowFast | mount | 2167 | 2207 | 5000 | |
| DetailsRowNoStyles | mount | 2006 | 2002 | 5000 | |
| Dialog | mount | 2590 | 2764 | 1000 | |
| DocumentCardTitle | mount | 238 | 224 | 1000 | |
| Dropdown | mount | 1977 | 1997 | 5000 | |
| FocusTrapZone | mount | 1108 | 1133 | 5000 | |
| FocusZone | mount | 1053 | 1066 | 5000 | |
| GroupedList | mount | 41392 | 41684 | 2 | |
| GroupedList | virtual-rerender | 19874 | 20132 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50752 | 51430 | 2 | |
| GroupedListV2 | mount | 231 | 231 | 2 | |
| GroupedListV2 | virtual-rerender | 212 | 212 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 237 | 240 | 2 | |
| IconButton | mount | 1066 | 1122 | 5000 | |
| Label | mount | 342 | 331 | 5000 | |
| Layer | mount | 2761 | 2724 | 5000 | |
| Link | mount | 393 | 398 | 5000 | |
| MenuButton | mount | 959 | 929 | 5000 | |
| MessageBar | mount | 21625 | 21636 | 5000 | |
| Nav | mount | 1964 | 1927 | 1000 | |
| OverflowSet | mount | 772 | 769 | 5000 | |
| Panel | mount | 1772 | 1761 | 1000 | |
| Persona | mount | 754 | 750 | 1000 | |
| Pivot | mount | 856 | 874 | 1000 | |
| PrimaryButton | mount | 850 | 849 | 5000 | |
| Rating | mount | 4637 | 4584 | 5000 | |
| SearchBox | mount | 904 | 917 | 5000 | |
| Shimmer | mount | 1878 | 1869 | 5000 | |
| Slider | mount | 1356 | 1332 | 5000 | |
| SpinButton | mount | 2870 | 2860 | 5000 | |
| Spinner | mount | 393 | 384 | 5000 | |
| SplitButton | mount | 1836 | 1870 | 5000 | |
| Stack | mount | 410 | 414 | 5000 | |
| StackWithIntrinsicChildren | mount | 840 | 842 | 5000 | |
| StackWithTextChildren | mount | 2649 | 2625 | 5000 | |
| SwatchColorPicker | mount | 6175 | 6175 | 5000 | |
| TagPicker | mount | 1501 | 1490 | 5000 | |
| Text | mount | 370 | 373 | 5000 | |
| TextField | mount | 911 | 924 | 5000 | |
| ThemeProvider | mount | 836 | 846 | 5000 | |
| ThemeProvider | virtual-rerender | 581 | 586 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1292 | 1295 | 5000 | |
| Toggle | mount | 615 | 627 | 5000 | |
| buttonNative | mount | 186 | 198 | 5000 |
Hotell
changed the title
* for inner workspace dependencies* for inner workspace dependencies
Hotell
force-pushed
the
hotell/deps/move-to-star-for-apps-deps-2
branch
2 times, most recently
from
af30191 to
c1aa28c
Compare
🕵 fluentuiv8 No visual regressions between this PR and main |
Hotell
force-pushed
the
hotell/deps/move-to-star-for-apps-deps-2
branch
from
c1aa28c to
0c39032
Compare
🕵 FluentUI-v0 No visual regressions between this PR and main |
Hotell
force-pushed
the
hotell/deps/move-to-star-for-apps-deps-2
branch
from
3d6ef7b to
a40705b
Compare
Hotell
requested review from
a team,
sopranopillow and
GeoffCoxMSFT
as code owners
Hotell
requested review from
spmonahan,
micahgodbolt,
smhigley and
a team
as code owners
|
once approved by v-build team this will be admin merged (pipelines are green) |
AtishayMsft
approved these changes
Jul 13, 2023
layershifter
approved these changes
Jul 13, 2023
TristanWatanabe
approved these changes
Jul 13, 2023
GeoffCoxMSFT
approved these changes
Jul 13, 2023
Hotell
force-pushed
the
hotell/deps/move-to-star-for-apps-deps-2
branch
from
a40705b to
ccea3d0
Compare
fabricteam
reviewed
Jul 13, 2023
| @@ -19,14 +19,14 @@ | |||
| }, | |||
There was a problem hiding this comment.
🕵 fluentuiv8 Open the Visual Regressions report to inspect the affected screenshots
ActivityItem 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| ActivityItem.Compact.default.chromium.png | 27 | Changed |
| ActivityItem.Root - RTL.default.chromium.png | 695 | Changed |
| ActivityItem.Root.default.chromium.png | 1083 | Changed |
Breadcrumb 14 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Breadcrumb.Root - RTL.itemLinkFocus.chromium.png | 7211 | Changed |
| Breadcrumb.Root.default.chromium.png | 7065 | Changed |
| Breadcrumb.Root.itemLinkFocus.chromium.png | 7416 | Changed |
| Breadcrumb.Root.overflowButtonFocus.chromium.png | 7118 | Changed |
| Breadcrumb.Root - RTL.click.chromium.png | 7334 | Changed |
| Breadcrumb.Root - RTL.overflowButtonFocus.chromium.png | 6908 | Changed |
| Breadcrumb.Root.longTitleHover.chromium.png | 7253 | Changed |
| Breadcrumb.Root - RTL.longTitleHover.chromium.png | 7029 | Changed |
| Breadcrumb.Root - RTL.default.chromium.png | 6862 | Changed |
| Breadcrumb.Root - RTL.shortTitleHover.chromium.png | 6938 | Changed |
| Breadcrumb.Root.click.chromium.png | 7084 | Changed |
| Breadcrumb.Root - RTL.hover.chromium.png | 7119 | Changed |
| Breadcrumb.Root.shortTitleHover.chromium.png | 7199 | Changed |
| Breadcrumb.Root.hover.chromium.png | 7337 | Changed |
🕵 FluentUIV0 No visual regressions between this PR and main |
🕵 fluentuiv9 No visual regressions between this PR and main |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 18, 2023
* master: (105 commits) fix(react-card): use resolved slot instead of raw prop object (microsoft#28517) applying package updates Expose virtualize index/length for casual use (microsoft#28450) applying package updates chore: update projects to use `*` for inner workspace dependencies (microsoft#28426) Update react-components/react-portal README.md (microsoft#28520) [2 of N] Changes for Making first render cycle faster and fixing test cases (microsoft#27721) applying package updates docs(react-search): Add README, description, best practices (microsoft#28507) Fix contrast issues in V8 Fluent2 Dark Theme (microsoft#28486) [VR-Approval-Cli] Fixed the Bug & Added the pipelineID (microsoft#28506) [Onboarding] Generalized VR-Approval-Cli (microsoft#28255) Onboarding [VR-Approval-CLI] To upload baseline screenshots (microsoft#28294) feat: migrate private v9 react packages to new preview versioning scheme (microsoft#28474) applying package updates applying package updates chore: openItems property added to TreeOpenChangeData + minor internal improvements (microsoft#28491) Fix Virtualizers 'start buffer' overflow (microsoft#28437) docs(v0 migration): add note about nested popups (microsoft#28480) chore: move slots back to TreeItem and creates slot context (microsoft#28492) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requirements
New Behavior
release
runs
yarn nx workspace-generator normalize-package-dependencieson pre-commit to normalize unwanted beachball changes.ci
new check added on CI to enforce
*versioning for inner workspace dependencies viayarn nx workspace-generator normalize-package-dependencies --verifypackages
applied
nx workspace-generators normalize-package-dependencieson whole workspacesyncpack
syncpack.config.jsin order to get better DX ( TS inteli-sense)DX/Dev flow updates
Adding inner workspace package to other publishable package dev dependencies:
// @filename packages/react-components/react-text/package.json { "name": "@fluentiu/react-text", "version": "9.1.2", "devDependencies": { - "@fluentui/react-jest-utils": "0.1.36" + "@fluentui/react-jest-utils": "*" } }Adding inner workspace package to any application dependencies:
// @filename apps/my-app/package.json { "name": "@fluentiu/my-app", "version": "0.0.0", "private": true, "dependencies": { - "@fluentui/react-lightsaber": "0.1.36" + "@fluentui/react-lightsaber": "*" } "devDependencies": { - "@fluentui/react-jest-utils": "0.1.36" + "@fluentui/react-jest-utils": "*" } }Related Issue(s)
*#28461