Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node parsing logic and use innerHTML, remove regex for perf #7076

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Feb 28, 2025

Pull Request

📖 Description

This change simplifies the logic by using innerHTML to parse and removes the regex which had perf implications. This brings the implementation more inline with how the html tag template works.

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu self-assigned this Feb 28, 2025
@janechu janechu merged commit 80a8f14 into features/btr Feb 28, 2025
5 checks passed
@janechu janechu deleted the users/janechu/convert-to-innerhtml branch February 28, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant