Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute and attribute bindings #7075

Merged

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Feb 27, 2025

Pull Request

📖 Description

This change adds logic for converting:

  • child nodes into strings
  • attributes into strings
  • attribute bindings (not inclusive of boolean attributes, events, or properties which will be separate PRs)

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu force-pushed the users/janechu/add-attribute-and-attribute-binding branch from bb26f9a to 1fa930e Compare February 27, 2025 19:14
janechu and others added 7 commits February 27, 2025 12:22
…ute.spec.ts

Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
…ute.spec.ts

Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
…ute.spec.ts

Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
…ute.spec.ts

Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
…ute.spec.ts

Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
…ute.spec.ts

Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
…ute.spec.ts

Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
@janechu janechu merged commit 8555606 into features/btr Feb 27, 2025
5 checks passed
@janechu janechu deleted the users/janechu/add-attribute-and-attribute-binding branch February 27, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants