Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support long and infinite timeouts in WaitForOrchestrationAsync #357

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

sebastianburckhardt
Copy link
Member

Currently, long or infinite timeout arguments to IOrchestrationServiceClient.WaitForOrchestrationAsync are not correctly handled:

  1. infinite timeouts (-1 milliseconds) are ignored and instead time out immediately
  2. long timeouts can lead to state pollution because they are persisted in the partition state until the timeout expires, even if the client is long gone.

To fix this, this PR adds some code to break long or infinite timeouts into 5-minute portions. It runs these portions in a loop until the timeout expires or the wait completes with a result.

@sebastianburckhardt sebastianburckhardt added this to the 1.4.3 milestone Mar 5, 2024
@sebastianburckhardt sebastianburckhardt merged commit a6924c0 into main Mar 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant