Fix hanging blob creation #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
98
to
100
| catch (Azure.RequestFailedException ex) when (BlobUtilsV12.BlobDoesNotExist(ex)) | ||
| { | ||
| } |
There was a problem hiding this comment.
So why are we swallowing this exception?
There was a problem hiding this comment.
I figured it would be good to at least log it, assuming the number of retries isn't all that large.
There was a problem hiding this comment.
After looking at this again, there is actually no reason to swallow the exception because it is not actually expected.
(This code is only called after a previous creation failed with an e-tag exception, so at that point the blob really should exist).
I am therefore removing this try-catch.
sebastianburckhardt
added a commit
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed an unnaturally large number of errors like "storage operation id=2438 has exceeded the time limit 00:01:30" that terminate the partition.
After analysis we found that this is caused by situations where a blob creation simultaneously succeeds (i.e. blob was created) and times out. Our retry path was not correctly detecting that the blob was already created.
This PR: