Update implementation to latest documented format #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add raw C3ID of primary key to hashes * Add all four bytes of CRC32 * Add CASK version number * Add CASK kind (key or hash + size) * Add day and hour to timestamp * Remove allocatorCode and secretEntropyInBytes * Move magic numbers to constants/properties * Remove ThreeByteSequence from tests. We don't actually need this helper with the way the format finally landed. This does not include HMACSHA384 support that is implied by the latest docs. That will be added separately and will likely involve some API refactoring.
nguerrera
force-pushed
the
format-update
branch
from
b18bbac to
888eee8
Compare
nguerrera
force-pushed
the
format-update
branch
2 times, most recently
from
2a417d0 to
fc85984
Compare
nguerrera
force-pushed
the
format-update
branch
from
fc85984 to
7036fa9
Compare
|
@michaelcfanning All feedback addressed. Please take another look. |
| // used as a production key. | ||
| // | ||
| // This is not considered final and needs more thought. We may move | ||
| // access to the underlying string elsewhere. |
There was a problem hiding this comment.
Hm. Interesting topic. Can we better control/get ahead of this via explicit/implicit type operators?
For debug builds, it'd be nice for CaskKey.ToString() to provide a breakdown of the key and its components. For release, ToString could dip into a managed underlying string if we take that route.
nguerrera
force-pushed
the
format-update
branch
2 times, most recently
from
5ada9a8 to
38416ab
Compare
nguerrera
force-pushed
the
format-update
branch
from
38416ab to
f7577f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not include HMACSHA384 support that is implied by the latest docs. That will be added separately and will likely involve some API refactoring.