Skip to content

Commit

Permalink
Split debug/release PR validation (#12)
Browse files Browse the repository at this point in the history
  • Loading branch information
nguerrera authored Dec 5, 2024
1 parent 2b43ddb commit 0542a8d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
15 changes: 5 additions & 10 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ jobs:
strategy:
matrix:
os: [windows-latest, ubuntu-latest, macos-latest]
configuration: [debug, release]
runs-on: ${{matrix.os}}
steps:
- name: Check out code
Expand All @@ -29,14 +30,8 @@ jobs:
- name: Check Formatting
run: dotnet format --verify-no-changes src

- name: Build (Debug)
run: dotnet build src -c Debug --no-restore
- name: Build
run: dotnet build src -c ${{matrix.configuration}} --no-restore

- name: Test (Debug)
run: dotnet test src -c Debug --no-build

- name: Build (Release)
run: dotnet build src -c Release --no-restore

- name: Test (Release)
run: dotnet test src -c Release --no-build
- name: Test
run: dotnet test src -c ${{matrix.configuration}} --no-build
1 change: 0 additions & 1 deletion devdocs/Questions.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
1. Name regex captures and add more regex test coverage.
1. Move magic numbers/chars to constants.
1. Use named arguments or better variables with good names for all string arguments in tests.
1. Use matrix to split debug/release tests onto different runs
1. Reduce repetition between UTF-8 and UTF-16 code paths if performant. If not performant, comment why there is a bit of repetition. Also consider risk of misleading to use UTF-8 API on base64-decoded bytes before changing this.
1. Run benchmarks somewhere on regular basis.
1. Make tests for invalid keys more resilient to implementation changes.
Expand Down

0 comments on commit 0542a8d

Please sign in to comment.