refresh rendered dataset after loading new dataset #9157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartguest
requested review from
kburtram,
anthonydresser and
Charles-Gagnon
|
Please change this PR to merge into master and then we'll cherry pick into 1.15 once we've got it in there. |
| @@ -394,6 +394,9 @@ export class EditDataGridPanel extends GridParentComponent { | |||
| undefinedDataSet.dataRows = undefined; | |||
| undefinedDataSet.resized = new Emitter(); | |||
| self.placeHolderDataSets.push(undefinedDataSet); | |||
| if (self.placeHolderDataSets[0]) { | |||
There was a problem hiding this comment.
This is always going to be true since the line above has us pushing the new undefinedDataSet into the array. So at the very least this is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The load dataset function now updates the rendered datasets upon loading a new dataSet (such as after a query).
This PR fixes #9145