Unused identifier fixes #9452
Merged
Unused identifier fixes #9452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhegazy This branch fixed my issue which I reported in the referenced PR :) |
|
thanks @DickvdBrink for getting back on this. please let me know if you see other issues. |
|
👍 one test pass is finished |
check for locals on for statments only mark private properties
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9402 and #9403
We defer checking function expressions and class expressions, and if we want to get the references marked correctly we need to do the reference validation after that is done.
This change refactors the unused local and parameter checking to use a list of deferred nodes to check later.
there are also some bug fixes that i ran into, like not reporting catch variable as unused, reporting unused type aliases, optional parameters, etc..