New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib): define TypedArray interface #47277

Closed

mfulton26 wants to merge 1 commit into microsoft:main from mfulton26:typed-array-interface

Contributor

mfulton26 commented Dec 31, 2021

Each concrete typed array type and constructor share common interfaces.

Library types can be defined extending base interfaces:

higher code reuse
less duplication
easier maintenance (less error prone)

Closes #15402
Fixes #45198
Fixes #45199


          feat(lib): define TypedArray interface

6dde81d

Each concrete typed array type and constructor share common interfaces.

Library types can be defined extending base interfaces:

1. higher code reuse
2. less duplication
3. easier maintenance (less error prone)

Closes #15402
Fixes #45198
Fixes #45199

Collaborator

typescript-bot commented Dec 31, 2021

It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src/lib' or possibly our lib generator. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src/lib' or https://github.com/microsoft/TypeScript-DOM-lib-generator

typescript-bot added the lib update label

typescript-bot assigned orta

typescript-bot added For Backlog Bug For Milestone Bug labels

ghost commented Dec 31, 2021 •

edited by ghost

Loading

All CLA requirements met.

Collaborator

typescript-bot commented Dec 31, 2021

The TypeScript team hasn't accepted the linked issue #15402. If you can get it accepted, this PR will have a better chance of being reviewed.

4 similar comments

Collaborator

typescript-bot commented Dec 31, 2021

The TypeScript team hasn't accepted the linked issue #15402. If you can get it accepted, this PR will have a better chance of being reviewed.

Collaborator

typescript-bot commented Dec 31, 2021

The TypeScript team hasn't accepted the linked issue #15402. If you can get it accepted, this PR will have a better chance of being reviewed.

Collaborator

typescript-bot commented Dec 31, 2021

The TypeScript team hasn't accepted the linked issue #15402. If you can get it accepted, this PR will have a better chance of being reviewed.

Collaborator

typescript-bot commented Dec 31, 2021

The TypeScript team hasn't accepted the linked issue #15402. If you can get it accepted, this PR will have a better chance of being reviewed.

Contributor Author

mfulton26 commented Dec 31, 2021

I thought for sure I edited under src; I'll close this one and make another

mfulton26 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Backlog Bug For Milestone Bug lib update