-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement code fix for override of js files #45780
Conversation
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
@stkevintan If you're going to take this over from @Kingwl, can you
|
Co-Authored-By: Wenlu Wang <kingwenlu@gmail.com>
Co-Authored-By: Wenlu Wang <kingwenlu@gmail.com>
Hi, @sandersn Sorry for the delay, I was on-call last weeks. |
I think it's fine to emit the comments, I just wondered why they changed from no-ops to emits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just waiting on an emit test now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a couple more minor things. Otherwise looking good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests still fail -- a couple of failures from the new tests and 5 more from existing tests.
Hi, @sandersn sorry for the delay. Just figure out the diagnostic messages have been improved for JS files in my previous #45656. so just wondering: is it necessary to specify a different descriptions of code fix action for js files as well ? PS: could you please help rerun the browser integration test ? it seems it failed with a transient error. |
Congrats @stkevintan ! Photograph looks handsome! @sandersn 😉 |
* feat: code fix for override in js files Co-Authored-By: Wenlu Wang <kingwenlu@gmail.com> * fix comments Co-Authored-By: Wenlu Wang <kingwenlu@gmail.com> * remove tryMergeJsdocTags * fix: bring the two methods back as functions * revert emitter changes * fix comments * fix: test failures Co-authored-by: Wenlu Wang <kingwenlu@gmail.com> Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Based on Kingwl#8
Fixes #39669
cc @sandersn @Kingwl