feat: add delegate to monitor training #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
==========================================
- Coverage 85.17% 83.97% -1.21%
==========================================
Files 186 186
Lines 8588 8603 +15
Branches 512 508 -4
==========================================
- Hits 7315 7224 -91
- Misses 1273 1379 +106
Continue to review full report at Codecov.
|
imatiach-msft
previously approved these changes
Mar 31, 2020
src/main/scala/com/microsoft/ml/spark/lightgbm/TrainUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/ml/spark/lightgbm/TrainUtils.scala
Outdated
Show resolved
Hide resolved
| @@ -325,4 +325,11 @@ trait LightGBMParams extends Wrappable with DefaultParamsWritable with HasWeight | |||
|
|
|||
| def getMinDataInLeaf: Int = $(minDataInLeaf) | |||
| def setMinDataInLeaf(value: Int): this.type = set(minDataInLeaf, value) | |||
|
|
|||
| var delegate: Option[LightGBMDelegate] = None | |||
There was a problem hiding this comment.
we should probably figure out how to make this inherit from param and expose in python layer, but maybe not for this PR
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
imatiach-msft
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is needed to monitor and hook in each training iteration.
It's because how well training my model and how much better metrics such as auc in each boost round.
contacts: keunhyun.oh@ahnlab.com