fix: Vowpal Wabbit kwargs + improvements #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated to VW 8.7.0.3 exposing VW internal performance statistics implemented VW native model export track timing metrics (learn, ingest, sync,...)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #692 +/- ##
===========================================
- Coverage 79.61% 34.79% -44.82%
===========================================
Files 226 176 -50
Lines 9011 7920 -1091
Branches 480 483 +3
===========================================
- Hits 7174 2756 -4418
- Misses 1837 5164 +3327
Continue to review full report at Codecov.
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@markus if you add WIP to the name it makes it so that it fails the WIP status check so others know when you are finished |
eisber
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
eisber
changed the title
src/main/scala/com/microsoft/ml/spark/vw/VowpalWabbitBase.scala
Outdated
Show resolved
Hide resolved
|
Also @eisber this page will help you eliminate some redundancy in test code https://app.codacy.com/manual/mhamilton723/mmlspark/pullRequest?prid=4158746 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/main/scala/com/microsoft/ml/spark/vw/VowpalWabbitBase.scala
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed VW kwargs (setLearningRate, setPowerT, ...)
updated to VW 8.7.0.3
exposing VW internal performance statistics
implemented VW native model export
track timing metrics (learn, ingest, sync,...)