feat: Add support for Azure Maps Search APIs #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SudhindraKovalam
commented
Dec 8, 2021
SudhindraKovalam
commented
- Add support for Azure Maps Get Search API
- Add support for Batch Search API
- Created a geospatial package to support all geospatial functions - Added support for GetSearchAddress - TODO: Fix the flattening of batch results
- fixed how the columns are fetched and flattened - added asserts to ensure the results `df` contains all rows
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1294 +/- ##
==========================================
- Coverage 78.04% 77.73% -0.32%
==========================================
Files 271 273 +2
Lines 13397 13453 +56
Branches 681 689 +8
==========================================
+ Hits 10456 10458 +2
- Misses 2941 2995 +54
Continue to review full report at Codecov.
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SudhindraKovalam
changed the title
SudhindraKovalam
changed the title
SudhindraKovalam
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
requested changes
Dec 9, 2021
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/geospatial/AzMapsSearchSchemas.scala
Outdated
Show resolved
Hide resolved
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/geospatial/AzureMapsBase.scala
Outdated
Show resolved
Hide resolved
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/geospatial/AzureMapsHelpers.scala
Outdated
Show resolved
Hide resolved
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/geospatial/AzureMapsSearch.scala
Outdated
Show resolved
Hide resolved
- [Review Comment] Removed `AzureMapsBase` class to simplify dependency - [Review Comment] Renamed `BatchAsyncReply` to `MapsAsyncReply` - [Review Comment] Removed `=None` assignments in schema classes - [Enhancements] Update Output Column to only return batch results making is easier to flatten responses.
- Updated test case to include realistic address data - fixed a potential issue with `MapAsyncReply` appending subscription key twice
- Explicitly set the user agent header to track SynapseML usage
mhamilton723
reviewed
Dec 9, 2021
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/geospatial/AzureMapsHelpers.scala
Show resolved
Hide resolved
- cleaned up `HasAddressInput`
mhamilton723
approved these changes
Dec 9, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.