Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to Text Api location #1235

Merged

Conversation

stuartleeks
Copy link
Contributor

Adds TEXT_API_LOCATION environment variable (defaults to eastus) to allow overriding the Cognitive Services, alongside the existing TEXT_API_KEY.

@stuartleeks stuartleeks force-pushed the sl/add-location-for-tests branch from ad2af4c to 0a4b026 Compare November 2, 2021 11:56
Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! One minor change!

@stuartleeks stuartleeks force-pushed the sl/add-location-for-tests branch from 5f8ac34 to b94c566 Compare November 5, 2021 16:26
@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #1235 (b94c566) into master (ba41290) will decrease coverage by 4.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1235      +/-   ##
==========================================
- Coverage   83.12%   78.15%   -4.97%     
==========================================
  Files         300      248      -52     
  Lines       13699    11984    -1715     
  Branches      660      660              
==========================================
- Hits        11387     9366    -2021     
- Misses       2312     2618     +306     
Impacted Files Coverage Δ
...la/org/apache/spark/ml/param/TypedArrayParam.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/synapse/ml/cognitive/FormRecognizerSchemas.scala 7.69% <0.00%> (-76.93%) ⬇️
...ala/org/apache/spark/ml/param/EstimatorParam.scala 12.50% <0.00%> (-75.00%) ⬇️
...ure/synapse/ml/cognitive/FormOntologyLearner.scala 15.55% <0.00%> (-71.12%) ⬇️
.../synapse/ml/cognitive/AnomalyDetectorSchemas.scala 33.33% <0.00%> (-66.67%) ⬇️
...ft/azure/synapse/ml/cognitive/TextTranslator.scala 26.69% <0.00%> (-54.52%) ⬇️
...oft/azure/synapse/ml/cognitive/TextAnalytics.scala 32.37% <0.00%> (-53.96%) ⬇️
.../azure/synapse/ml/cognitive/AnomalyDetection.scala 30.69% <0.00%> (-52.48%) ⬇️
...ft/azure/synapse/ml/cognitive/FormRecognizer.scala 35.00% <0.00%> (-47.00%) ⬇️
...ft/azure/synapse/ml/cognitive/ComputerVision.scala 40.81% <0.00%> (-37.76%) ⬇️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba41290...b94c566. Read the comment docs.

@mhamilton723 mhamilton723 merged commit 23a997b into microsoft:master Nov 8, 2021
@stuartleeks stuartleeks deleted the sl/add-location-for-tests branch November 8, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants