Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destructor Tombstones #5318

Merged
merged 18 commits into from
Mar 3, 2025
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions stl/inc/xstring
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,19 @@ public:

_CONSTEXPR20 _String_val() noexcept : _Bx() {}

#if _MSVC_STL_DESTRUCTOR_TOMBSTONES
_CONSTEXPR20 ~_String_val() noexcept {
if constexpr (is_pointer_v<pointer>) {
if (!_STD _Is_constant_evaluated()) {
const auto _Tombstone{reinterpret_cast<pointer>(_MSVC_STL_UINTPTR_TOMBSTONE_VALUE)};
_Bx._Ptr = _Tombstone;
_Mysize = 0;
_Myres = (_Small_string_capacity + 1) | _Alloc_mask; // first capacity when entering large mode
}
}
}
#endif // _MSVC_STL_DESTRUCTOR_TOMBSTONES

// length of internal buffer, [1, 16] (NB: used by the debugger visualizer)
static constexpr size_type _BUF_SIZE = 16 / sizeof(value_type) < 1 ? 1 : 16 / sizeof(value_type);
// roundup mask for allocated buffers, [0, 15]
Expand Down