Update libcxx skips for a new compiler warning #5283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
LGTM. Also agreed with the suggestion to improve how the core issue is referenced, as suggested here: https://github.com/microsoft/STL/pull/5283/files#r1957058780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors internal MSVC-PR-610616 "Zc for conformant u8 string encoding of escape sequences".
(I'm refraining from nitpicking the comment too closely because updating it requires rerunning the internal PR checks and that's time-consuming.)
These are phrased as
:9 SKIPPEDwhich skips them for the MSVC-internal test harness only, as the new warning has not yet shipped. When it does, we'll need to update this to:0 FAILand:1 FAIL, or work with upstream LLVM to fix their non-conformant test code.