Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid testing infinities in /fp:fast #4937

Merged
merged 2 commits into from
Sep 9, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions tests/std/tests/VSO_0000000_vector_algorithms_floats/test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,19 @@ void test_min_max_element_floating_any(mt19937_64& gen) {

constexpr auto input_of_input_size = dataCount / 2;
vector<T> input_of_input(input_of_input_size);
input_of_input[0] = -numeric_limits<T>::infinity();
input_of_input[1] = +numeric_limits<T>::infinity();
input_of_input[2] = -0.0;
input_of_input[3] = +0.0;
for (size_t i = 4; i < input_of_input_size; ++i) {

input_of_input[0] = -0.0;
input_of_input[1] = +0.0;
#ifndef _M_FP_FAST
constexpr size_t special_values_count = 2;
#else // ^^^ defined(_M_FP_FAST) / !defined(_M_FP_FAST) vvv
input_of_input[2] = -numeric_limits<T>::infinity();
input_of_input[3] = +numeric_limits<T>::infinity();

constexpr size_t special_values_count = 4;
#endif // ^^^ !defined(_M_FP_FAST) ^^^

for (size_t i = special_values_count; i < input_of_input_size; ++i) {
input_of_input[i] = dis(gen);
}

Expand Down