Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<chrono> formatting: sys_info, local_info, feature-test macro #1860

Merged
merged 7 commits into from
Apr 20, 2021

Conversation

StephanTLavavej
Copy link
Member

  • Define and test the feature-test macro.
  • Implement and test sys_info and local_info.
    • sys_info's abbrev is a narrow string, so I've implemented _Widen_string. Is this ok?
    • sys_info and local_info streaming are unspecified, so I chose something reasonable.
    • When printing sys_info's seconds offset and minutes save, there are FIXMEs because the formatter for duration is not yet implemented.
    • When local_info is unique, second contains no information, so we don't need to print it.
    • When printing local_info with anything other than empty braces, we need to reject non-unique values (first and second will have different offsets and abbrevs).
    • I'm using hh_mm_ss to print the offset, and generalizing it to handle the previous codepath.

@StephanTLavavej StephanTLavavej added cxx20 C++20 feature chrono C++20 chrono labels Apr 19, 2021
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 19, 2021 11:46
@StephanTLavavej StephanTLavavej merged commit 39c722f into microsoft:chronat2 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chrono C++20 chrono cxx20 C++20 feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants