Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silence future "unused capture" warning #1522

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

CaseyCarter
Copy link
Contributor

@CaseyCarter CaseyCarter commented Dec 9, 2020

Hello, people of 2020! I've traveled back in time to silence a warning about an unused lambda capture that will some day appear without warning, giving birth to Skynet and bringing about the end of days. You're welcome.

[This ports the changes from internal MSVC-PR-292175.]

Hello, people of 2020! I've traveled back in time to silence a warning about an unused lambda capture that will some day appear without warning, giving birth to Skynet and bringing about the end of days. You're welcome.
@CaseyCarter CaseyCarter added the test Related to test code label Dec 9, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner December 9, 2020 19:39
@CaseyCarter
Copy link
Contributor Author

Hello, people of 2020! I've traveled back in time to silence a warning about an unused lambda capture that will some day appear without warning, giving birth to Skynet and bringing about the end of days. You're welcome.

Thanks, future me! We really appreciate the fix. (And the lottery numbers, 😉.)

Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question is, will you be back?

@mnatsuhara mnatsuhara removed their assignment Dec 14, 2020
@StephanTLavavej StephanTLavavej merged commit 335449f into microsoft:master Dec 15, 2020
@StephanTLavavej
Copy link
Member

Thanks for protecting the timeline! 🤖 I've merged this as it has already been merged to MSVC. As this is test-only and the warning itself was changed to be off-by-default (in MSVC-PR-292482), I believe it falls below the Changelog threshold.

fengjixuchui added a commit to fengjixuchui/STL that referenced this pull request Dec 15, 2020
Silence future "unused capture" warning (microsoft#1522)
@CaseyCarter CaseyCarter deleted the port branch December 16, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants