Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/format] add parse_precision. #1333

Merged
merged 5 commits into from
Oct 16, 2020

Conversation

barcharcraz
Copy link
Member

adds parse_precision and tests. Tests are a tad lighter than other parse functions because it mostly relies on stuff already tested elsewhere.

@barcharcraz barcharcraz requested a review from a team as a code owner October 1, 2020 21:24
@CaseyCarter CaseyCarter added the cxx20 C++20 feature label Oct 2, 2020
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (with todo cards filed), feel free to squash this into feature/format when you're ready. Thanks!

@StephanTLavavej StephanTLavavej removed their assignment Oct 16, 2020
@StephanTLavavej StephanTLavavej added the format C++20/23 format label Oct 16, 2020
@barcharcraz barcharcraz merged commit 0668a74 into microsoft:feature/format Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx20 C++20 feature format C++20/23 format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants