Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/spaceship: Clause 20: pair, tuple, optional #1206

Merged
merged 70 commits into from
Feb 22, 2021
Merged

feature/spaceship: Clause 20: pair, tuple, optional #1206

merged 70 commits into from
Feb 22, 2021

Conversation

cbezault
Copy link
Contributor

@cbezault cbezault commented Aug 18, 2020 •
edited by StephanTLavavej
Loading

Also removes workaround for DevCom-583764 / VSO-900973 "operator<=> is not called if there is an operator that returns a pointer", fixed by MSVC-PR-286030 on Nov 9, 2020.

@cbezault cbezault added cxx20 C++20 feature spaceship C++20 operator <=> labels Aug 18, 2020
@cbezault cbezault requested a review from a team as a code owner August 18, 2020 21:31
@cbezault cbezault force-pushed the feature/spaceship/utility branch from d972c0a to 144f0d3 Compare August 19, 2020 18:41
@cbezault cbezault force-pushed the feature/spaceship/utility branch from 70fdd7a to 33f023b Compare August 19, 2020 21:52
@StephanTLavavej StephanTLavavej changed the title feature/spaceship: Clause 20: Tuple and Optional feature/spaceship: Clause 20: pair, tuple, optional Feb 20, 2021
StephanTLavavej
StephanTLavavej reviewed Feb 20, 2021
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll push a batch of changes, then I believe this is ready to merge!

@StephanTLavavej
Copy link
Member

I've reported DevCom-1344701 "Spaceship operator return type using pack expansion emits bogus error C2672".

CaseyCarter
CaseyCarter approved these changes Feb 22, 2021
View reviewed changes
@CaseyCarter CaseyCarter removed their assignment Feb 22, 2021
@StephanTLavavej StephanTLavavej merged commit 5547f0f into microsoft:feature/spaceship Feb 22, 2021
@StephanTLavavej
Copy link
Member

Thanks for spaceship-izing these major parts of Clause 20, and finding a compiler bug along the way! 🛸 🪲 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
cxx20 C++20 feature spaceship C++20 operator <=>
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cbezault @StephanTLavavej @CaseyCarter @ahanamuk