/std:c++latest configs are /permissive or /permissive- #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So our test coverage won't be damaged when the compiler changes `/std:c++latest` to imply `/permissive-`. I do so by adding `/permissive-` to every `/std:c++latest` command line that doesn't yet have it, and then reverting one configuration in each matrix to `/permissive`. It seems sensible to me that the majority of our coverage should change from permissive to strict mode to reflect the change in compiler default.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
BillyONeal
approved these changes
Aug 10, 2020
Do you want me to drag someone over here, or are you happy enough for me to add a reviewer to the internal PR? |
|
Internal is fine |
StephanTLavavej
requested changes
Aug 12, 2020
StephanTLavavej
approved these changes
Aug 14, 2020
StephanTLavavej
approved these changes
Aug 14, 2020
|
Timing assumption in the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Closing the loop: I convinced @JonCavesMSFT to signoff on the internal MSVC-PR-267794. |
|
Something something "strict" pun. I think this falls below the threshold of being interesting enough to Changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So our test coverage won't be damaged when the compiler changes
/std:c++latestto imply/permissive-. I do so by adding/permissive-to every/std:c++latestcommand line that doesn't yet have it, and then reverting one configuration in each matrix to/permissive. It seems sensible to me that the majority of our coverage should change from permissive to strict mode to reflect the change in compiler default.Fixes #435