Implement counted_iterator #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added some unit tests. There are two remaining major problems:
I have uncommented them for now to get the tests passing -at least locally- so that we can flesh out some other potential bugs through other compiler/configurations NOTE: this is also missing tests for the |
CaseyCarter
suggested changes
Jul 24, 2020
miscco
commented
Jul 25, 2020
cpplearner
reviewed
Jul 26, 2020
Closed
cpplearner
reviewed
Jul 28, 2020
Co-authored-by: S. B. Tam <cpplearner@outlook.com>
CaseyCarter
approved these changes
Aug 11, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
StephanTLavavej
requested changes
Aug 12, 2020
miscco
commented
Aug 12, 2020
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
CaseyCarter
approved these changes
Aug 13, 2020
StephanTLavavej
approved these changes
Aug 14, 2020
Commit STL's tweaks. Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Comment change I overlooked in the previous update. Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
StephanTLavavej
approved these changes
Aug 14, 2020
miscco
commented
Aug 14, 2020
|
I knew I could count on you to get this implemented! 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress implementation of
std::counted_iteratorI am quite happy where I am right now. However, there are quite some sharp edges I would like to discuss.
The standard has a frequent precondition that both iterators should be of the same range. It is rather tough to implement that. I tried my best but maybe you have a better idea.
I have strengthened
noexceptwhere I feel comfortable. There are most certainly other possibilitiesThere is something strange with the
iter_moverequirement, as it fails forstd::vector<int>in the death tests.I have some further work in progress regarding actual unit tests beyond the iterator machinery, but they need way more polish so I have not yet added them.
Partially addresses #39