[PTRun]Workaround fix tooltip crash on .net 6 #16629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansjfw
approved these changes
Feb 28, 2022
htcfreek
approved these changes
Feb 28, 2022
mshtang
pushed a commit
to mshtang/PowerToys
that referenced
this pull request
Feb 28, 2022
jaimecbernardo
added a commit
to jaimecbernardo/PowerToys
that referenced
this pull request
Mar 14, 2022
This reverts commit b4250c1.
jaimecbernardo
added a commit
that referenced
this pull request
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
There seems to be a racing condition in .net 6 which causes a crash when a popup disappears in the virtualized list view used by the PowerToys Run results.
dotnet/wpf#5730 (comment)
We shouldn't release with a crashing regression, so this PR hopes to provide a workaround that doesn't impact users too much.
The fix for this in .net is expected to be released on the next release so we should revisit there.
What is included in the PR:
Show new tooltips right away, so that the previous tooltip isn't cleaned when the virtualized item has been removed.
How does someone test / validate:
Try to replicate the linked issue and verify it no longer replicates.
Quality Checklist