Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2-preview1 release #1906

Merged
merged 796 commits into from
Nov 6, 2024

Merge pull request #1904 from microsoft/release/2.0.0

7f4f935
Select commit
Loading
Failed to load commit list.
Merged

V2-preview1 release #1906

Merge pull request #1904 from microsoft/release/2.0.0
7f4f935
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Nov 5, 2024 in 3s

34 new alerts

New alerts in code changed by this pull request

  • 30 warnings
  • 4 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 97 in src/Microsoft.OpenApi/Models/OpenApiComponents.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check notice on line 516 in src/Microsoft.OpenApi/Models/OpenApiDocument.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed opportunity to use Where Note

This foreach loop
implicitly filters its target sequence
Loading
- consider filtering the sequence explicitly using '.Where(...)'.

Check warning on line 72 in src/Microsoft.OpenApi/Models/OpenApiExample.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 75 in src/Microsoft.OpenApi/Models/OpenApiExample.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 117 in src/Microsoft.OpenApi/Models/OpenApiHeader.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 173 in src/Microsoft.OpenApi/Models/OpenApiParameter.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 261 in src/Microsoft.OpenApi/Models/OpenApiParameter.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dubious type test of 'this' Warning

Testing whether 'this' is an instance of
OpenApiFormDataParameter
Loading
in
OpenApiParameter
Loading
introduces a dependency cycle between the two types.

Check warning on line 265 in src/Microsoft.OpenApi/Models/OpenApiParameter.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dubious type test of 'this' Warning

Testing whether 'this' is an instance of
OpenApiBodyParameter
Loading
in
OpenApiParameter
Loading
introduces a dependency cycle between the two types.

Check warning on line 289 in src/Microsoft.OpenApi/Models/OpenApiParameter.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dubious type test of 'this' Warning

Testing whether 'this' is an instance of
OpenApiBodyParameter
Loading
in
OpenApiParameter
Loading
introduces a dependency cycle between the two types.

Check notice on line 128 in src/Microsoft.OpenApi/Models/OpenApiRequestBody.cs

See this annotation in the file changed.

Code scanning / CodeQL

Inefficient use of ContainsKey Note

Inefficient use of 'ContainsKey' and
indexer
Loading
.

Check warning on line 349 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 349 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 350 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 350 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 351 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 351 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 352 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 353 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 353 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 354 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 354 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 355 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 356 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 356 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.

Check warning on line 357 in src/Microsoft.OpenApi/Models/OpenApiSchema.cs

See this annotation in the file changed.

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.