Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes JsonSchema reference resolution when parsing a doc. #1627

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

irvinesunday
Copy link
Contributor

@irvinesunday irvinesunday commented Apr 15, 2024

This PR:

  • Partially closes Post v2 Preview Checklist #1613
  • Removes JsonSchema reference resolution step when parsing a doc.
  • Splits JsonSchema reference resolution from the reference host document setting into separate classes.
  • Updates some tests in line with the above changes.
  • Deletes some tests that were not relevant in light of the above changes.

NB: By removing JsonSchema reference resolution, we now don't validate whether the JsonSchema references concrete instances are defined in the components/schemas section of a document (locally or externally).

@irvinesunday irvinesunday merged commit f069dc1 into release/2.0.0 Apr 22, 2024
6 of 8 checks passed
@irvinesunday irvinesunday deleted the is/do-not-resolve-jsonschema branch April 22, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants