Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delete operations for media entities #523

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Add delete operations for media entities #523

merged 5 commits into from
Apr 29, 2024

Conversation

millicentachieng
Copy link
Member

@millicentachieng millicentachieng commented Apr 25, 2024 •
edited
Loading

Fixes #522
This PR:

  • Adds DELETE operations for media content paths unless there are annotations specifying that an entity isn't deletable
  • Adds tests to check that the operation details are correct

@millicentachieng millicentachieng marked this pull request as ready for review April 25, 2024 12:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.2% Coverage on New Code
1.8% Duplication on New Code

See analysis details on SonarCloud

@millicentachieng millicentachieng merged commit 7874361 into master Apr 29, 2024
12 checks passed
@millicentachieng millicentachieng deleted the ma/add-delete-to-media-entities branch April 29, 2024 11:38
This was referenced May 7, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethj-msft garethj-msft garethj-msft left review comments

@andrueastman andrueastman andrueastman approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@coseguera coseguera Awaiting requested review from coseguera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Deletability support for media entities
3 participants
@millicentachieng @garethj-msft @andrueastman