Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error ranges for OData actions #229

Merged
merged 4 commits into from
Jun 6, 2022

Conversation

millicentachieng
Copy link
Member

@millicentachieng millicentachieng commented Jun 2, 2022

Fixes (#218)

Add error ranges for OData actions if ErrorResponsesAsDefault is set to false.

image

@millicentachieng millicentachieng self-assigned this Jun 2, 2022
@millicentachieng millicentachieng linked an issue Jun 2, 2022 that may be closed by this pull request
@millicentachieng millicentachieng marked this pull request as ready for review June 2, 2022 18:55
@millicentachieng millicentachieng requested a review from baywet June 2, 2022 20:47
baywet
baywet previously approved these changes Jun 3, 2022
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing that and sorry for missing it at the first place. Can you add an entry in the csproj changelog please?

peombwa
peombwa previously approved these changes Jun 3, 2022
@millicentachieng millicentachieng dismissed stale reviews from peombwa and baywet via ecb609c June 6, 2022 15:11
@irvinesunday irvinesunday merged commit fba1c33 into master Jun 6, 2022
@irvinesunday irvinesunday deleted the fix-error-ranges-for-odata-actions branch June 6, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odata actions do not have error ranges described
5 participants