Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provides support for using the range of response status code 2XX #215

Merged
merged 10 commits into from
Jun 6, 2022
Merged

Provides support for using the range of response status code 2XX #215

merged 10 commits into from
Jun 6, 2022

Conversation

irvinesunday
Copy link
Contributor

Closes #153

This PR:

  • Adds a new convert setting UseHTTPStatusCodeClass2XX that can be used to toggle between using a specific response status code or using a status code range identifier - 2XX. This setting is set to false by default.
  • Uses this convert setting to toggle between setting the specific status code or using the status code range identifier.
  • Updates tests to validate the above.

@irvinesunday irvinesunday requested review from peombwa and baywet April 27, 2022 17:41
@irvinesunday irvinesunday self-assigned this Apr 27, 2022
@baywet baywet added this to the 1.0.10-release milestone May 2, 2022
@irvinesunday irvinesunday modified the milestones: 1.0.10-release, 1.1 May 10, 2022
@peombwa peombwa mentioned this pull request May 10, 2022
Closed
@baywet baywet modified the milestones: 1.1, 1.0.11 May 19, 2022
baywet
baywet requested changes Jun 3, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. A few minor things left.
csproj changelog entry + PR is conflicting

peombwa
peombwa previously approved these changes Jun 6, 2022
View reviewed changes
@baywet baywet requested a review from peombwa June 6, 2022 21:49
@baywet baywet enabled auto-merge June 6, 2022 21:49
@irvinesunday irvinesunday disabled auto-merge June 6, 2022 21:51
@irvinesunday irvinesunday merged commit 079f8ea into master Jun 6, 2022
@irvinesunday irvinesunday deleted the is/feature/status-code-class-2XX branch June 6, 2022 21:51
@baywet baywet mentioned this pull request Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

Assignees

@irvinesunday irvinesunday

Labels
None yet
Projects
None yet
Milestone
OData:1.0.11
Development

Successfully merging this pull request may close these issues.

[Feature] Support for a range of response status codes
4 participants
@irvinesunday @darrelmiller @peombwa @baywet