Rework format lint checks for pre-commit #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… run checks and formatting instead
Merged
motus
approved these changes
Jan 3, 2025
motus
pushed a commit
that referenced
this pull request
Jan 3, 2025
# Pull Request ## Title Updates most of the python code for updated syntax after #904 --- ## Description - Reformats the code in bulks with `pyupgrade` - Apply some additional autoflake and isort fixes for the no longer necessary imports. - Fixup a few places that need to use `__futures__ import annotations` for forward references in type hints (and run pyupgrade again to remove the previous quoted string versions). - Adjusts a few docstrings, but not all of the `Optional` and `Union` ones (due to difficulties with regex and matching braces). - Closes #749 --- ## Type of Change - 🔄 Refactor --- ## Testing Usual CI --- ## Additional Notes (optional) Should be merged after #904 ---
Merged
motus
pushed a commit
that referenced
this pull request
Jan 4, 2025
# Pull Request ## Title Remove use of yq. --- ## Description Removes the use of yq which doesn't always exist and running it via conda apparently has issues. --- ## Type of Change - 🛠️ Bug fix --- ## Testing CI --- ## Additional Notes (optional) Fixes a bug introduced in #904 ---
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Reworks build to use pre-commit for format and lint checks.
Description
As mentioned in #902 and #903, this refactors the build system to use
pre-commitfor the following reasons:less complicated Makefile rules
pinned linter versions that can be checked with dependabot more explicitly for easier maintenance
See Also: Consider dropping support for python 3.8 and/or 3.9 #749
Type of Change
Testing
Manually locally and usual CI tests.
Additional Notes (optional)
This builds off of #903 and is prep work to change the syntax of the codebase using
pyupgrade.