A test configuration for the environment based on local shell scripts #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges and added comments in other parts of the local env config
bpkroth
reviewed
Oct 25, 2024
mlos_bench/mlos_bench/tests/config/environments/local/scripts/bench_run.py
Show resolved
Hide resolved
bpkroth
reviewed
Oct 25, 2024
mlos_bench/mlos_bench/tests/config/cli/test-cli-local-env-bench.jsonc
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Oct 25, 2024
mlos_bench/mlos_bench/tests/config/cli/test-cli-local-env-opt.jsonc
Outdated
Show resolved
Hide resolved
…ring environment as shell env variables
…/test/barebone_local
bpkroth
approved these changes
Nov 1, 2024
mlos_bench/mlos_bench/tests/config/environments/local/scripts/bench_run.py
Show resolved
Hide resolved
|
Lgtm. A few extra explanation comments wouldn't hurt, but can expand those in a future PR too. |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
A test configuration for the environment based on local shell scripts
Description
This is a sample MLOS configuration (CLI config, tunables, environment, and the scripts) that launches a local environment and invokes local shell scripts to set it up and run trials.
Type of Change
This is purely a config-based update. We might add unit tests around that setup later.
Testing
Unit tests that validate the environment and run test experiments are included in this PR.
To test the environment manually, run:
mlos_bench \ --config mlos_bench/mlos_bench/tests/config/cli/test-cli-local-env-bench.jsonc \ --globals experiment_test_local.jsonc \ --tunable_values tunable-values/tunable-values-local.jsoncAdditional Notes (optional)
This setup is supposed to serve as an example of other local environments with shell scripts.