Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conda Updates #705

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Conda Updates #705

merged 6 commits into from
Mar 7, 2024

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Mar 7, 2024 •
edited
Loading

@bpkroth bpkroth requested a review from a team as a code owner March 7, 2024 20:17
@bpkroth bpkroth marked this pull request as draft March 7, 2024 20:17
@bpkroth bpkroth marked this pull request as ready for review March 7, 2024 21:03
@bpkroth bpkroth enabled auto-merge (squash) March 7, 2024 21:09
@bpkroth bpkroth merged commit 28b07b1 into microsoft:main Mar 7, 2024
12 checks passed
@bpkroth bpkroth deleted the conda-vers-update branch March 7, 2024 21:57
@motus motus mentioned this pull request Mar 8, 2024
Merged
motus added a commit that referenced this pull request Mar 13, 2024
@motus
Roll back forceful assignment of PATH when invoking a local process (#…
d7c4334 
…708)

Roll back one of the updates from #705 
It breaks tests on both Windows and WSL DevContainer on my PC.
* On Windows, `environ` may not have `PATH` at all
* On my WSL DevContainer, passing non-null `env` to `subprocess.run`
prevents it from finding the right python interpreter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motus motus motus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpkroth @motus