Handle some mypy errors and increase test coverage #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 19, 2024
motus
added a commit
that referenced
this pull request
Feb 20, 2024
motus
added a commit
that referenced
this pull request
Feb 20, 2024
Simply makes sure that pyarrow is available in the conda environment to make some warnings go away. Assumes that future versions of pandas will declare their own dependency on pyarrow and this can be removed. Also includes changes from #680 --------- Co-authored-by: Sergiy Matusevych <sergiym@microsoft.com>
bpkroth
added a commit
that referenced
this pull request
Feb 20, 2024
Addressing some warnings from pandas about datetime conversions and deprecated and future strict behavior. One issue we currently have is that a timestamp produced by a client may be in a different timezone or lack timezone info from what that receiver parses before injecting it into the DB. This starts to at least attempt to work on those conversions for consistency. Currently also includes changes from #682 and #680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our one hot encoding previously had some conditional handling of 1 dimensional DataFrames.
That doesn't exist - those are Series. As such, the typing returns recently started alerting (due to an upstream dependency bump).
Moreover, we lacked test coverage for that path.
This change makes it more clear what those type expectations are and adds tests.