use named constants to define columns containing IDs and generic values #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motus
added
bug
bpkroth
reviewed
Feb 14, 2024
bpkroth
reviewed
Feb 14, 2024
|
bumped up the ID and value lengths to 512 and 1024 correspondingly. That's an increase from our current 255/255 limit that would still allow us to use optimization_target in a primary key on MySQL |
Rework constants to allow overrides
…STATUS column; minor pylint fixes
bpkroth
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, make
objectives.optimization_targetuse the new_LEN_IDconstant to make sure it is not too long to be used as a primary key in MySQL (issue #677)Closes #677