You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable fluent-bit threading by default and make it optional since fluent-bit has bug (fluent/fluent-bit#7071) with threaded. Once the fluent-bit fixes threading bug, then this can be configurable.
why are we exposing this via configmap? once the bug is fixed shouldn't we just change to code for everyone to threaded on?
this bug is active since quite sometime and when they fixed, we can ask internal customers to configure the configmap and validate . Potentially, we can make default if its reliable after the validation.
why are we exposing this via configmap? once the bug is fixed shouldn't we just change to code for everyone to threaded on?
this bug is active since quite sometime and when they fixed, we can ask internal customers to configure the configmap and validate . Potentially, we can make default if its reliable after the validation.
ok. pls add the bug link here to correlate in the future.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable fluent-bit threading by default and make it optional since fluent-bit has bug (fluent/fluent-bit#7071) with threaded. Once the fluent-bit fixes threading bug, then this can be configurable.